Fix accessibility issues suggested by WAVE#1193
Draft
ankurjuneja wants to merge 1 commit intodevelopfrom
Draft
Conversation
labkey-jeckels
requested changes
Apr 13, 2026
| <td class="representative details-control newPrecursor <%=precursor.getNewPrecursorId()%>"> | ||
| <span class="<%=precursor.getNewPrecursorId()%>_<%=precursor.getOldPrecursorId()%>"> | ||
| <img src="<%=getWebappURL("_images/plus.gif")%>"/> | ||
| <img src="<%=getWebappURL("_images/plus.gif")%>" alt="Expand row details"/> |
Contributor
There was a problem hiding this comment.
These should flip when we swap the plus for a minus on lines 122 and 127.
|
|
||
| btnHtml += '<span class="qc-paging-prev ' + (this.pagingStartIndex > 0 ? 'qc-paging-icon-enabled' : 'qc-paging-icon-disabled') | ||
| + '"><i class="fa fa-angle-left"></i></span>'; | ||
| + '" role="button" aria-label="Previous page"><i class="fa fa-angle-left" aria-hidden="true"></i></span>'; |
Contributor
There was a problem hiding this comment.
isn't keyboard focusable by default. It's probably best to switch these to , which would let us drop the role="button" and would mean that we wouldn't need to toggle an aria-disabled attribute when the control is disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/878
Related Pull Requests
Changes